fix: problem when providing urls with parameters #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don`t know what the problem here is https://github.com/7nohe/openapi-react-query-codegen/actions/runs/8394740113/job/22992524284?pr=46 @7nohe, any suggestions? |
7nohe
requested changes
Mar 23, 2024
Co-authored-by: Urata Daiki <[email protected]>
7nohe
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR obsoletes: #40
Problem
I noticed that the parameters I provide to a request won't get replaced. So
/customers/{id}becomes/customers/%7Bid%7D, and the request fails after 3 retries ...TLDR;
/customers/{id}becomes/customers/%7Bid%7D?id=35467709-efc5-4e87-a09e-f7f2151afd50instead of
/customers/35467709-efc5-4e87-a09e-f7f2151afd50Fix
I used the request interceptors to replace all placeholders (e.g.
{id}) with the corresponding value (fromconfig.params)Other
Also see this comment: axios/axios#706 (comment)